[Desktop-lite] desktop-init.sh drops entrypoint args due to heredoc variable expansion#1621
Merged
Merged
Conversation
Mathiyarasy
changed the title
abdurriq
approved these changes
Apr 14, 2026
uraitakahito
added a commit
to uraitakahito/features
that referenced
this pull request
May 20, 2026
Verified by re-running test_desktop_init_exec_passthrough; upstream's quoted form works after upstream devcontainers#1621 (desktop-init.sh heredoc fix, 9f086c0) which is now in our merge history. The earlier fork-side simplification to "\$@" is no longer necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1615
The desktop-lite feature's install.sh generates the entrypoint script desktop-init.sh using an unquoted heredoc (cat << EOF). At the end of this heredoc,
$1 and $@were not escaped, so they expanded to empty strings at install time. So any command passed to the container entrypoint was silently ignored.